Bases of Docker containers

doccano / doccano

Open source annotation tool for machine learning practitioners.

MIT License

9.42k stars 1.72k forks source link

Bases of Docker containers #1112

Closed kuraga closed 3 years ago

kuraga commented 3 years ago

@Hironsan , IMHO every part of doccano should be Alpine-, Debian or Ubuntu-based.

Nginx's Docker base is Alpine,
Node's Docker base ~was Ubuntu~ is Alpine,
Python's Docker base ~was Ubuntu~ ~was Alpine~ is Debian.

Thoughts?

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label question to this issue, with a confidence of 0.64. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Hironsan commented 3 years ago

Alpine is useful for smaller images. But in Python, it can take quiet time to build images. So I changed the image from Alpine to slim-buster.

Using Alpine can make Python Docker builds 50× slower

Are there any concerns?

kuraga commented 3 years ago

Alpine, Debian and Ubuntu even use different standard C libraries. Feel free to close but IMHO to have same bases is better even than (size-optimized) Alpine. And

But in Python, it can take quiet time

IMHO is not an issue. We build once only.

ricjhill commented 3 years ago

Alpine, Debian and Ubuntu even use different standard C libraries. Feel free to close but IMHO to have same bases is better even than (size-optimized) Alpine. And

Agreed.

kuraga commented 3 years ago

By another side using a precompiled versions (i.e. "wheels" i.e. non-Alpine) could be better...

But even that IMHO the base have to be the same.