docker-library / memcached

Docker Official Image packaging for memcached
http://memcached.org/
BSD 3-Clause "New" or "Revised" License
131 stars 99 forks source link

Upgrade to Alpine 3.11 #55

Closed J0WI closed 4 years ago

tianon commented 4 years ago

I did a make test > /tests.log 2>&1 on Alpine 3.10 and Alpine 3.11 to try and help narrow down what's failing here, but it doesn't really provide many more clues: :disappointed:

$ diff -u before.log after.log
--- before.log  2019-12-20 16:31:57.346755375 -0800
+++ after.log   2019-12-20 16:32:07.082483919 -0800
@@ -68,7 +68,7 @@
 ok 51 - shutdown
 ok 52 - stop_server
 getaddrinfo(): Name does not resolve
-failed to listen on TCP port 31503: Resource temporarily unavailable
+failed to listen on TCP port 47919: Resource temporarily unavailable
 slab class   1: chunk size        96 perslab   10922
 slab class   2: chunk size       120 perslab    8738
 slab class   3: chunk size       152 perslab    6898
@@ -109,6 +109,8 @@
 slab class  38: chunk size    394840 perslab       2
 slab class  39: chunk size    524288 perslab       2
 <26 server listening (auto-negotiate)
+<27 new auto-negotiating client connection
+<27 connection closed.
 slab class   1: chunk size        96 perslab   10922
 slab class   2: chunk size       120 perslab    8738
 slab class   3: chunk size       152 perslab    6898
@@ -220,6 +222,7 @@
 t/extstore-jbod.t ........... ok
 t/extstore.t ................ ok
 t/flags.t ................... ok
+Succeeded!!!
 t/flush-all.t ............... ok
 t/getandtouch.t ............. ok
 t/getset.t .................. ok
@@ -278,9 +281,12 @@
 # Data that should expire while stopped.
 # killed, waiting
 Gracefully stopping
-# reconnected
-# low TTL item should be gone
-t/restart.t ................. ok
+Failed to connect to unix domain socket: No such file or directory '/tmp/memcachetest.3009.2' at t/restart.t line 108.
+# Tests were run but no plan was declared and done_testing() was not seen.
+# Looks like your test exited with 2 just after 49.
+t/restart.t ................. 
+Dubious, test returned 2 (wstat 512, 0x200)
+All 49 subtests passed 
 t/slabhang.t ................ skipped: Test is flaky. Needs special hooks.
 t/slabs-reassign-chunked.t .. ok
 t/slabs-reassign2.t ......... ok
@@ -289,7 +295,7 @@
 t/ssl_ports.t ............... skipped: SSL testing is not enabled
 t/ssl_settings.t ............ skipped: SSL testing is not enabled
 t/ssl_verify_modes.t ........ skipped: SSL testing is not enabled
-PORT: 48092
+PORT: 33781
 t/stats-conns.t ............. ok
 t/stats-detail.t ............ ok
 t/stats.t ................... ok
@@ -299,30 +305,12 @@
 t/watcher.t ................. ok
 t/watcher_connid.t .......... ok
 t/whitespace.t .............. skipped: Skipping tests probably because you don't have git.
-All tests successful.
-Files=76, Tests=64223, 336 wallclock secs ( 7.95 usr  0.57 sys + 15.88 cusr  4.55 csys = 28.95 CPU)
-Result: PASS
-File 'assoc.c' Lines executed:85.38% of 130 Creating 'assoc.c.gcov'
-File 'authfile.c' Lines executed:86.96% of 46 Creating 'authfile.c.gcov'
-File 'bipbuffer.c' Lines executed:80.00% of 65 Creating 'bipbuffer.c.gcov'
-File 'cache.c' Lines executed:46.99% of 83 Creating 'cache.c.gcov'
-File 'crawler.c' Lines executed:80.43% of 368 Creating 'crawler.c.gcov'
-File 'crc32c.c' Lines executed:68.57% of 140 Creating 'crc32c.c.gcov'
-File 'daemon.c' Lines executed:52.00% of 25 Creating 'daemon.c.gcov'
-File 'extstore.c' Lines executed:86.76% of 506 Creating 'extstore.c.gcov'
-File 'hash.c' Lines executed:100.00% of 10 Creating 'hash.c.gcov'
-File 'items.c' Lines executed:88.96% of 1078 Creating 'items.c.gcov'
-File 'itoa_ljust.c' Lines executed:76.92% of 52 Creating 'itoa_ljust.c.gcov'
-File 'jenkins_hash.c' Lines executed:69.15% of 94 Creating 'jenkins_hash.c.gcov'
-File 'logger.c' Lines executed:72.96% of 429 Creating 'logger.c.gcov'
-File 'memcached.c' Lines executed:70.23% of 5241 Creating 'memcached.c.gcov'
-File 'murmur3_hash.c' Lines executed:100.00% of 34 Creating 'murmur3_hash.c.gcov'
-File 'restart.c' Lines executed:84.54% of 194 Creating 'restart.c.gcov'
-File 'sasl_defs.c' Lines executed:0.00% of 61 Creating 'sasl_defs.c.gcov'
-File 'slab_automove.c' Lines executed:88.89% of 72 Creating 'slab_automove.c.gcov'
-File 'slab_automove_extstore.c' Lines executed:70.97% of 155 Creating 'slab_automove_extstore.c.gcov'
-File 'slabs.c' Lines executed:80.18% of 676 Creating 'slabs.c.gcov'
-File 'stats.c' Lines executed:91.58% of 95 Creating 'stats.c.gcov'
-File 'storage.c' Lines executed:91.07% of 347 Creating 'storage.c.gcov'
-File 'thread.c' Lines executed:81.80% of 445 Creating 'thread.c.gcov'
-File 'util.c' Lines executed:96.61% of 118 Creating 'util.c.gcov' File '/usr/include/ctype.h' Lines executed:100.00% of 1 Creating 'ctype.h.gcov'
+
+Test Summary Report
+-------------------
+t/restart.t               (Wstat: 512 Tests: 49 Failed: 0)
+  Non-zero exit status: 2
+  Parse errors: No plan found in TAP output
+Files=76, Tests=64180, 339 wallclock secs ( 7.19 usr  0.53 sys + 16.72 cusr  5.10 csys = 29.54 CPU)
+Result: FAIL
+make: *** [Makefile:2021: test] Error 1
tianon commented 4 years ago

I tested this while working on #56 and I think the 1.5.21 release fixed whatever was going wrong, so this should be good to go now (I've just rebased it accordingly).

tianon commented 4 years ago

... welp, that did not work. Why did it work when I did both this and enable TLS in #56?? :confused:

tianon commented 4 years ago

Heh, somehow enabling TLS makes the build no longer fail (I rebased this on top of the merge of #56).