search

docker-mailserver / docker-mailserver-helm

Kubernetes Helm chart for docker-mailserver
https://github.com/docker-mailserver/docker-mailserver/
MIT License
107 stars 67 forks source link

Restart pod when deploying with changes to configmap.yaml #37

Closed abh closed 2 years ago

abh commented 3 years ago

It seemed rude to bump the chart version number unless you think it's appropriate that each change would just be a new release. Maybe that's not so crazy. 🤷

funkypenguin commented 3 years ago

As I understand it, that's best-practice, so go ahead and bump the chart (semver) version for each change ;)

abh commented 2 years ago

Bumped the chart version. Since you already have two branches going effectively I did the later one. Should I make the PR against your personal repository instead?

abh commented 2 years ago

ah, never mind. Here's a clean version against the org version. :-)

funkypenguin commented 2 years ago

Thanks @abh ... Since I started using flux to manage my deployments, I'm no longer a fan of the checksum-based approach, since when certain automation (like flux) is used, it generates unnecessary deployment restarts (see https://github.com/minio/minio/pull/14396 for a similar issue).

I'd rather support the ability of the operator to specify custom deployment annotations (see deployment.annotations), and then rely on something like https://github.com/stakater/Reloader to trigger the deployment restarts. Perhaps adding this to the existing documentation could be a new repo issue?

Cheers! D