fbartels
commented
5 years ago One way to tackle this would be to add an .editorconfig config file into the repository. Not all editors support this standard out of the box, but this would be a way to define the expected behavior in this project.
Current output of ´eclint´ (xargs stops after the first command has failed, therefore only errors of ´setup.sh´ are shown):
$ git ls-files --exclude='*.sh' --ignored | xargs --max-lines=1 eclint check
setup.sh
152:01 ❌ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
153:01 ❌ invalid indent size: 5, expected: 6 (EditorConfig indent_size https://goo.gl/QtGB8R)
154:01 ❌ invalid indent size: 5, expected: 6 (EditorConfig indent_size https://goo.gl/QtGB8R)
276:01 ❌ invalid indent style: tab, expected: space
(EditorConfig indent_style https://goo.gl/8Qkrbr)
erik-wramner
georglauterbach
The scripts are not formatted according to the standard and as a consequence there is a mix of indentation sizes, sometimes tabs are used but mostly spaces. It makes it harder to work with the code, in particular when blocks of code are copied/moved between files that use different conventions. In particular the start-mailserver.sh script uses tabs in some places and spaces in others and indents with 8 spaces, whereas the standard is to only use two spaces and no tabs.
Possible Fix
I can fix the scripts (or at least start-mailserver.sh to begin with), but as this will cause major changes I would like to do it at an agreed point in time when we try to avoid having outstanding work. Merging real changes when there are whitespace changes all over is not my idea of fun!