search

docker / engine-api

DEPRECATED: Please see https://github.com/docker/docker/tree/master/client
Apache License 2.0
264 stars 163 forks source link

Add Annotations to Task definition to fix partial/full filter issue in `service tasks --filter` #350

Closed yongtang closed 8 years ago

yongtang commented 8 years ago

This fix is related to docker pull request: https://github.com/docker/docker/pull/24850

and swarmkit pull request: https://github.com/docker/swarmkit/pull/1193

Basically, this fix adds Annotations to Task definition so that Task name could be saved. The Task name is defined as

<ServiceName>.<Slot>.<TaskID>

Signed-off-by: Yong Tang yong.tang.github@outlook.com

aaronlehmann commented 8 years ago

LGTM (not a maintainer)

vdemeester commented 8 years ago

LGTM 🐮 @aaronlehmann yes you are :stuck_out_tongue_closed_eyes: https://github.com/docker/engine-api/blob/master/MAINTAINERS#L14

aaronlehmann commented 8 years ago

I can't merge PRs...

vdemeester commented 8 years ago

ah,.. ping @thaJeztah @icecrime

thaJeztah commented 8 years ago

I pinged @dmp42 to give @aaronlehmann access, let me merge this