search

docker / engine-api

DEPRECATED: Please see https://github.com/docker/docker/tree/master/client
Apache License 2.0
264 stars 163 forks source link

replace .Active by .Enabled #351

Closed vieux closed 8 years ago

vieux commented 8 years ago

ping @tiborvass @anusha-ragunathan

related to https://github.com/docker/docker/pull/25424

tiborvass commented 8 years ago

Cross posting from https://github.com/docker/docker/pull/25424#issuecomment-237715136: I wonder if it should be State: Enabled instead.

anusha-ragunathan commented 8 years ago

LGTM

stevvooe commented 8 years ago

LGTM after documenting the field

I am not convinced a state machine will help here, without developing a proper model around the state machine.

vieux commented 8 years ago

PTAL @stevvooe

tiborvass commented 8 years ago

LGTM

stevvooe commented 8 years ago

LGTM