docker / engine-api

DEPRECATED: Please see https://github.com/docker/docker/tree/master/client
Apache License 2.0
264 stars 163 forks source link

cancellable: use sync.Once to prevent double channel close #357

Closed LK4D4 closed 8 years ago

LK4D4 commented 8 years ago

ping @tonistiigi

tonistiigi commented 8 years ago

@LK4D4 Would it make sense to just remove notifyingReader if it's not used for anything?

LGTM

LK4D4 commented 8 years ago

@tonistiigi I noticed that Do uses it. It waits on that channel there.

vdemeester commented 8 years ago

LGTM :cat: