docker / setup-qemu-action

GitHub Action to install QEMU static binaries
https://github.com/marketplace/actions/docker-setup-qemu
Apache License 2.0
456 stars 61 forks source link

Fail action on unsupported architecture #158

Open jacob-carlborg opened 3 months ago

jacob-carlborg commented 3 months ago

Contributing guidelines

I've found a bug, and:

Description

The action continues to run when an unsupported architecture is specified. The problem is that I specified mips64el as the architecture instead of mips64le.

Expected behaviour

I expected the action to fail.

Actual behaviour

The action continues to run an completes successfully.

Repository URL

https://github.com/jacob-carlborg/lime

Workflow run URL

https://github.com/jacob-carlborg/lime/actions/runs/10162079184/job/28101982775

YAML workflow

- name: Set up QEMU
        uses: docker/setup-qemu-action@v3
        with:
          platforms: mips64el

Workflow logs

No response

BuildKit logs

No response

Additional info

No response

crazy-max commented 3 months ago

Agreed, we should fail in such case: https://github.com/jacob-carlborg/lime/actions/runs/10162079184/job/28101982775#step:6:195

  /usr/bin/docker run --rm --privileged docker.io/tonistiigi/binfmt:latest --install mips64el
  installing: mips64el unsupported architecture: mips64el

image

Should be fixed upstream https://github.com/tonistiigi/binfmt