dockette / adminer

:whale: Tiniest boxed dockerized Adminer (MySQL, PostgreSQL, SQLite, Mongo, Oracle) Dockerfiles
MIT License
85 stars 29 forks source link

adminer-editor image uses an outdated version of the app #29

Closed W1M0R closed 4 years ago

W1M0R commented 4 years ago

The adminer-editor Dockerfile indicates that ADMINER_EDITOR_VERSION=4.7.0 is being used. A newer version is available.

You should be able to use a similar command when updating the ADMINER_VERSION:

find . -type f -name Dockerfile -exec sed -i '' 's/ENV ADMINER_EDITOR_VERSION=.*/ENV ADMINER_EDITOR_VERSION=4.7.X/g' {} +

Alternatively, you could add the following lines to your Dockerfile to make it possible for consumers to set the version via docker build args:

ARG ADMINER_EDITOR_VERSION=4.7.5
ENV ADMINER_EDITOR_VERSION=${ADMINER_EDITOR_VERSION}
f3l1x commented 4 years ago

I've added your bash oneliner to the readme, thanks.

f3l1x commented 4 years ago

Also update to latest version https://github.com/dockette/adminer/commit/742dd579bef22cd6d6f0df79d525e42cf10c88ac#diff-41419fbc789f9bf01eec132b50c80da2