Closed trusktr closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docsify-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 30, 2023 2:55am |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 8d5d20480a75878e802a0acf32f1da0495100b21:
Sandbox | Source |
---|---|
docsify-template | Configuration |
Use Angular commit message to generate change logs
Use Angular commit message to generate change logs
Updated
Looks like the codesandbox build sometimes fails when its system limits the number of process (EAGAIN error).
Is there a way to make it retry?
I tried to access the admin codesandbox before, but I don't have access. Previously added by @anikethsaha , Can you help to see it?
No reply from @anikethsaha yet.
@sy-records @Koooooo-7 codesandbox build is not required, so we can continue anyway.
@Koooooo-7 Because you already approved, and I merged develop and tests passed but it undid your approval, and then @sy-records approved, I'll go ahead and merge.
Part of
Summary
SSR was experimental and incomplete, namely not working with plugins, generally not an ideal way to manage code (duplication of Renderer), and none of us have shown any desire to continue implementing that path.
I have better ideas (discord discussion) on the how to leverage tools like Solid Start, Astro, or Qwik.js for SSR and SSG in ways that will be way better than what we had going on.
So this removes SSR, which we believe is not the ideal way to proceed.
Later, when someone desires and has the time, they can propose a new and complete SSR/SSG implementation that is on a good path, not duplicating a bunch of logic, ideally aligned with modern tech.
Thought leaders from Next.js, Nuxt.js, Solid Start, SvelteKit, and more recently the generic solutions Astro and Qwik, have been ironing out the details of SSR, SSG, CSG for a looooong time; they are masters at it. We should pursue a robust modern solution based on those when we sit down to finally do this.
What kind of change does this PR introduce?
Feature removal: delete SSR.
For any code change,
Does this PR introduce a breaking change? (check one)
Breaking change because someone might be using it. This requires a major version bump.
Related issue, if any:
I am planning to finish a few more things in a row here:
https://github.com/docsifyjs/docsify/issues/2104.
We can wait for all of those (except perhaps TypeScript) before releasing a major version bump so that we don't release several major version bumps back to back.
Tested in the following browsers: