docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.47k stars 5.67k forks source link

chore: add missing Vue support for Vercel builds #2134

Closed trusktr closed 1 year ago

trusktr commented 1 year ago

Summary

We currently have two index.html files (why is that again?). One file was not loading Vue stuff.

Without the Vue support in Vercel builds, we were unable to fully verify pull request builds, therefore unable to confirm if Vue broke or not. Now we can manually check Vue functionality for PRs.

What kind of change does this PR introduce?

Add Vue support to the index.html file that didn't have it.

For any code change,

Does this PR introduce a breaking change? (check one)

No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 10:03am
Koooooo-7 commented 1 year ago

Hi @trusktr , That's what I work on the 2 index.html sometimes.

One is /doc/index.html, which we could host it as docsify live site, which import external .../docsify@4/lib/docsify.min.js (we could check current live behavior). One is /index.html, thats for the dev locally, which import /lib/docsify.js (we could check the dev/changed behavior).

We could have a compare on them easily.

Maybe we should sync common files index.html, README...on time in case of having some different except dev changes.