docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.82k stars 5.68k forks source link

docs: Removal of flags for language choice drop-down #2468

Closed akshaybhinge19 closed 4 months ago

akshaybhinge19 commented 4 months ago

Summary

Country specific flags should not be associated with language choices. Solution: List of languages without flags

Related issue, if any:

2458

What kind of change does this PR introduce?

Feature

For any code change,

Does this PR introduce a breaking change?

No

Tested in the following browsers:

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:12pm
akshaybhinge19 commented 4 months ago

Hi @akshaybhinge19 , thx for your contribution. As I mentioned, we do the translation refinement for the v5 release now. This change gonna be suspended for now.

@Koooooo-7 Thanks for the update. Sorry, I misunderstood it as being under the 5.x milestone. Can we update this?

image

sy-records commented 4 months ago

Thank you for your contribution. I've set it as a draft for now and will merge it in when we're sure.

jhildenbiddle commented 4 months ago

@sy-records @Koooooo-7 --

I think we can safely merge this PR. It's just removing flag emojis. The changes will be merged to develop which already has v5-related doc updates, so we won't merge develop into main until v5 is ready anyway.