Refactor of Jammit - Githubissues

documentcloud / jammit

Industrial Strength Asset Packaging for Rails

http://documentcloud.github.com/jammit/

MIT License

1.16k stars 197 forks source link

Refactor of Jammit #227

Closed didip closed 12 years ago

didip commented 12 years ago

Upgraded development and test Gemfile
Able to switch to 4 different JS compressors: jsmin, yui, closure, or uglifier.
Able to switch to 3 different CSS compressors: cssmin, yui, or sass.
New attributes: Jammit.css_compressors and Jammit.javascript_compressors.
All tests now explicitly use :yui
New compressors:

  lib/jammit/cssmin_compressor.rb
  lib/jammit/jsmin_compressor.rb
  lib/jammit/sass_compressor.rb

cssmin and jsmin is the new lowest common denominator default.
All tests pass.

jashkenas commented 12 years ago

... provisionally -- looks great. One big question:

Why are you vendoring cssmin and jsmin when they're perfectly well available as gems?

didip commented 12 years ago

Great question! Thanks for replying!

This pull request is the first pass of refactoring, just in case core developers have any feedback.

I vendored both because it was easier to do during the refactoring.

On Mar 29, 2012, at 7:53 AM, Jeremy Ashkenas wrote:

... provisionally -- looks great. One big question:

Why are you vendoring cssmin and jsmin when they're perfectly well available as gems?

Reply to this email directly or view it on GitHub: https://github.com/documentcloud/jammit/pull/227#issuecomment-4821803

jashkenas commented 12 years ago

Great -- then please update the pull request to reflect your complete and final proposed version, and we'll take another look.

didip commented 12 years ago

@jashkenas The pull request is now ready for code review.

jashkenas commented 12 years ago

Looks good -- although I hope that folks don't start using CSSMin and JSMin in production, just because they'll be here by default.