Declarative DSL - Githubissues

dojo / app

:rocket: Dojo 2 - an application framework.

http://dojo.io

Other

8 stars 14 forks source link

Declarative DSL #63

Closed novemberborn closed 8 years ago

novemberborn commented 8 years ago

Implements most of #33. Supports app-action, app-actions, app-element, app-store and app-widget (for widget registration).

Builds on #62.

[x] Trial with todo-mvc https://github.com/dojo/examples/pull/56

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #63 into master will not change coverage

@@           master   #63   diff @@
===================================
  Files          11    12     +1   
  Lines         700   920   +220   
  Methods         2     3     +1   
  Messages        0     0          
  Branches      128   191    +63   
===================================
+ Hits          700   920   +220   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update e513f95...8d71d94

novemberborn commented 8 years ago

Pushed a fixup for my earlier comments, and a big refactor of extractRegistrationElements which came about as I was fixing strict null check violations in another branch (that already contained this merge).

novemberborn commented 8 years ago

(once we sort out CI)

https://travis-ci.org/dojo/app/builds/164598735 failed due to socket hangups, and uploadCoverage is failing. So I'm pretty sure CI passes…