Add @types migration. - Githubissues

lzhoucs commented 8 years ago

Type: feature

Description: This PR adds @types migration for dojo/app. It is based on https://github.com/dojo/app/pull/89 which does dojo-interfaces migration. There's one unit test failing which is caused by out-dated dependency: dojo-store. To address this, we need to:

Land all opened dojo-store PRs: https://github.com/dojo/stores/pulls and create a release for it
Land this PR
Land @maier49's work: https://github.com/dojo/app/compare/master...maier49:integrate-stores-mvp

Related Issue: #90

Please review this checklist before submitting your PR:

[x] There is a related issue
[X] All contributors have signed a CLA
[x] All code matches the style guide
[ ] The code passes the CI tests
[ ] Unit or Functional tests are included in the PR
[x] The PR increases or maintains the overall unit test coverage percentage
[x] The code is ready to be merged

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #91 into master will not change coverage

@@           master   #91   diff @@
===================================
  Files          11    11          
  Lines         938   938          
  Methods         7     7          
  Messages        0     0          
  Branches      194   194          
===================================
  Hits          938   938          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 5aaad5c...0aa92d3

agubler commented 7 years ago

Closing as outdated now.

dojo / app

Add @types migration. #91

Current coverage is 100% (diff: 100%)