search

dokku / docker-container-healthchecker

Runs healthchecks against local docker containers
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Document `type` #168

Open strugee opened 5 months ago

strugee commented 5 months ago

Description of feature

Both the README and https://dokku.com/docs/deployment/zero-downtime-deploys/ state that type may be one of startup, readiness, or liveness, but they don't actually say what this means! It would be nice to have this information available.

erickedji commented 5 months ago

Seems to refer to this, but not sure if applied to local docker outside of the default startup type: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

josegonzalez commented 5 months ago

Yeah it refers to that, but the docker-local scheduler only supports the startup type. All are supported for the k3s scheduler.

In the future, the custom proxy plugins might enable some sort of support for the readiness type so that they don't proxy to things that can't be proxied to yet. We might also finally have a proper daemon that does healthchecks for the docker-local scheduler and handles restarts appropriately.