search

dokku / docker-container-healthchecker

Runs healthchecks against local docker containers
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Command based healthchecks #91

Closed IgnisDa closed 1 year ago

IgnisDa commented 1 year ago

Description of feature

Looking at options in https://dokku.com/docs/deployment/zero-downtime-deploys/#customizing-checks, I think commands are not allowed as healthchecks.

I am using an image that has a command is_ready (much like pg_isready) that returns a non-zero exit status if the service is not ready. I would like to use this instead of a web based check for my service.

josegonzalez commented 1 year ago

Commands are allowed in healthchecks under 0.31.x. The example only shows a simple web check.

Docs might be wrong though, seems it should be a list: https://github.com/dokku/docker-container-healthchecker/blob/master/tests/fixtures/app.json#L25-L27

IgnisDa commented 1 year ago

Unrelated, but is it possible to get the output of a command based healthcheck?

josegonzalez commented 1 year ago

Output is only shown on error.

IgnisDa commented 1 year ago

Its not for me image

using version 0.6.4.

josegonzalez commented 1 year ago

Mind filing a bug for that?