Use --archive --gzip in import/export

dokku / dokku-mongo

a mongo plugin for dokku

MIT License

174 stars 32 forks source link

Use --archive --gzip in import/export #85

Closed ebeigarts closed 6 years ago

ebeigarts commented 7 years ago

~~Fixes tests on OS X by using gnu readline~~
Updated default mongo version from 3.2.9 to 3.4.12
mongo:export uses --archive --gzip (requires mongo 3.2+)
mongo:export silences STDERR since STDERR is converted to STDOUT when using ssh -t, also other *:export plugins are silent.
mongo:import uses --archive --gzip --nsFrom ... --nsTo ... (requires mongo 3.4+)

Fixes #70, #84.

I have tested import/export directly on the server and also through ssh -t. it works.

jcutrono commented 7 years ago

I was just about to start this one. Thank you ebeigarts!

jcutrono commented 7 years ago

Any idea when this will be rolled out?

josegonzalez commented 7 years ago

Mind rebasing this onto master, @ebeigarts ? Ideally we don't have so many unrelated changes in a single PR.

ebeigarts commented 7 years ago

@josegonzalez rebase done

josegonzalez commented 7 years ago

This breaks usage of older versions of mongodb for import/export. Do we think that is fine to do?

ebeigarts commented 7 years ago

yes, it brakes, but this is more standardized way of exporting/importing. maybe we can add some post-install notes or warning in readme about backwards incompatible changes? and bump version to 1.1.0?

ebeigarts commented 7 years ago

Everything should be fine for users running mongo 3.2+, for users running 3.0, they would need to first upgrade containers running 3.0 to 3.2, and then update the plugin, because the new export needs 3.2+

jcutrono commented 7 years ago

Agreed with @ebeigarts comments. This makes usage much more standard. Bumping the version number and some release notes should cover it.

jcutrono commented 6 years ago

@josegonzalez still looking for this. Can you give me write access and ill take over?

josegonzalez commented 6 years ago

Closed by #93.