search

dolanmiu / ng-color

Simple Angular color picker components which follow Angular best practices. No Frills.
https://stackblitz.com/edit/ng-color-demo
12 stars 6 forks source link

saturation-lightness-preview causes overflow of the hue slider #4

Closed nla-brandonjames closed 6 years ago

nla-brandonjames commented 7 years ago

See attached screenshot. screen shot 2017-04-17 at 10 58 35 am

The hue slider overflows off of this modal window.

dolanmiu commented 7 years ago

which modal is this? bootstrap?

nla-brandonjames commented 7 years ago

Yes. ngx-bootstrap modal.

dolanmiu commented 7 years ago

are you fixing this right now?

If so,

I would like to restructure this project such under src/, each color picker type will be in its own respective folder, which I think would make more sense

What do you think?

nla-brandonjames commented 7 years ago

Yeah. It sounds fine to me. One thing that may be nice to have in the future is "swatches" like graphics editor software. That could be included and structured in that way.

dolanmiu commented 7 years ago

yes, stuff like swatches can be added in src/common, so other color picker types within the lib can utilise them

dolanmiu commented 6 years ago

Closing because the preview color picker is deprecated