search

dolthub / dolt

Dolt – Git for Data
https://www.dolthub.com
Apache License 2.0
18k stars 516 forks source link

Hacky Float/Decimal Implementation #6358

Open jycor opened 1 year ago

jycor commented 1 year ago

Currently, the portion of code that determines if an inputted number is parsed as a Float or Decimal expression relies on string comparisons. Additionally, the decisions that the parser makes at this stage affects the output type, which maybe shouldn't be the case.

A less hacky implementation of that section of is here: https://github.com/dolthub/go-mysql-server/pull/1876 However, this fails a bunch of test, bringing up several (different) issues with matching the expected types MySQL returns.

max-hoffman commented 1 year ago

related:

max-hoffman commented 7 months ago

@jycor How are we feeling about this? Can we make more specific statements about certain queries that fail related to this?