search

dolthub / dolt

Dolt – Git for Data
https://www.dolthub.com
Apache License 2.0
18k stars 516 forks source link

[no-release-notes] Refactor methods that parse messages to return the message id tag. #8521

Closed nicktobey closed 2 weeks ago

nicktobey commented 3 weeks ago

Reading a serialized message should return the message type. This allows callers who don't know the message type to switch on it, and callers that expect a certain message type can validate it.

This provides extra validation checks in some places, and streamlines code in others.

coffeegoddd commented 3 weeks ago

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c5497aa ok 5937457
version total_tests
c5497aa 5937457
correctness_percentage
100.0
coffeegoddd commented 3 weeks ago

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7757645 ok 5937457
version total_tests
7757645 5937457
correctness_percentage
100.0
coffeegoddd commented 3 weeks ago

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3ec6edd ok 5937457
version total_tests
3ec6edd 5937457
correctness_percentage
100.0
coffeegoddd commented 2 weeks ago

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bfd296f ok 5937457
version total_tests
bfd296f 5937457
correctness_percentage
100.0
coffeegoddd commented 2 weeks ago

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
cb93e00 ok 5937457
version total_tests
cb93e00 5937457
correctness_percentage
100.0