dolthub / go-mysql-server

A MySQL-compatible relational database with a storage agnostic query engine. Implemented in pure Go.
Apache License 2.0
2.37k stars 211 forks source link

remove `resolveDescribeQuery` rule #2726

Closed jycor closed 1 month ago

jycor commented 1 month ago

This rule just recurses into the analyzer, so we should just do it right at the beginning, so we should do it right away and avoid calling all other rules.

This would be better/cleaner in the planbuilder, but we would need to tell the analyzer to not analyze this node or skip it somehow.

It's possible to move this logic into analyzeWithSelector. It might be more difficult to move this above Analyze, as we'd have to put this logic in a variety of places.