Closed xC0dex closed 1 month ago
I guess there's not an easy way to add a test for this, right?
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.50%. Comparing base (
d11913e
) to head (0e7b686
). Report is 6 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I guess there's not an easy way to add a test for this, right?
You're right. It’s hard to test as it happens during the dotnet pack
command.
However, I tested it locally by publishing Swashbuckle and using the package in a multi target project. Before the change the document was generated during the build. After the change this was no longer the case.
Pull Request
The issue or feature being addressed
This PR fixes #2706 by passing the defined
Swashbuckle.AspNetCore.props
file to thebuildMultiTargeting
directory, which is used for outer builds (Multi targeting).Details on the issue fix or feature implementation
The props file defines that the
OpenApiGenerateDocumentsOnBuild
property is false by default if it's not set. However, this was not set for multi targeting projects. So the document was generated during the build.