domaindrivendev / Swashbuckle.AspNetCore

Swagger tools for documenting API's built on ASP.NET Core
MIT License
5.26k stars 1.32k forks source link

Recreate package lock files #3146

Closed Saibamen closed 2 weeks ago

Saibamen commented 2 weeks ago

Before npm ci:

added 270 packages, and audited 271 packages in 4s

92 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

node_modules folder size: 76.6 MB

After:

added 228 packages, and audited 229 packages in 4s

92 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

node_modules folder size: 69.8 MB
codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.11%. Comparing base (e759f46) to head (f34decb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3146 +/- ## ======================================= Coverage 82.11% 82.11% ======================================= Files 76 76 Lines 3125 3125 Branches 526 526 ======================================= Hits 2566 2566 Misses 559 559 ``` | [Flag](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `82.11% <ø> (ø)` | | | [Windows](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `82.11% <ø> (ø)` | | | [macOS](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `82.11% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martincostello commented 2 weeks ago

What's the benefit of you doing this manually? Dependabot will auto-regenerate it when npm dependencies get updated.

Saibamen commented 2 weeks ago

Dependabot can't migrate to latest package-lock version v3.

And IIRC Dependabot is updating only packages from package.json, not internal packages inside package-lock.json

EDIT: For example, it can't update node_modules/@babel/runtime from 7.24.5 to 7.26.0 (or it is option to enable this?)

martincostello commented 2 weeks ago

Dependabot can't migrate to latest package-lock version v3.

Ah, I hadn't noticed they were still on the older lockfile format.

martincostello commented 2 weeks ago

Thanks!