search

domainr / dnsr

Iterative DNS resolver for Go (golang).
MIT License
125 stars 23 forks source link

Draft: Wrote test to check TXT results with default golang LookupTXT #112

Closed Miniwoffer closed 9 months ago

Miniwoffer commented 11 months ago

tests for: https://github.com/domainr/dnsr/issues/111

Integralist commented 11 months ago

Looks like the TestGoogleTXT test fails:

=== RUN   TestGoogleTXT
    resolver_test.go:30: TXT record "globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=" not found
    resolver_test.go:30: TXT record "google-site-verification=wD8N7i1JTNTkezJ49swvWW48f8_9xveREV4oB-0Hf5o" not found
    resolver_test.go:30: TXT record "webexdomainverification.8YX6G=6e6922db-e3e6-4a36-904e-a805c28087fa" not found
    resolver_test.go:30: TXT record "MS=E4A68B9AB2BB9670BCE1[54](https://github.com/domainr/dnsr/actions/runs/7421023746/job/20194239527?pr=112#step:6:55)12F62916164C0B20BB" not found
    resolver_test.go:30: TXT record "v=spf1 include:_spf.google.com ~all" not found
    resolver_test.go:30: TXT record "google-site-verification=TV9-DBe4R80X4v0M4U_bd_J9cpOJM0nikft0jAgjmsQ" not found
    resolver_test.go:34: TXT record count mismatch: 6 != 12

Which I guess makes sense due to the original logic comment...

// Google will have at least an SPF record, but might transiently have verification records too.

This would be why it used >= instead.

Miniwoffer commented 11 months ago

Yeah, this was created in reference to https://github.com/domainr/dnsr/issues/111, its suppose to fail.

Miniwoffer commented 11 months ago

Should probably have tagged it as Draft or something.

Integralist commented 11 months ago

That's OK no worries, I'll move it to a Draft PR for now. Thanks!

Miniwoffer commented 11 months ago

@Integralist Make another MR for the fix #113. I could make these tests a little more race-condition-safe by retrying a few times on failure, but if you feel like its an unnecessary test you can just close it.

cee-dub commented 9 months ago

Superseded by #120