search

dominick-han / homebridge-tv-cec

Homebridge support for TV power on/off, source selection, using HDMI-CEC
GNU General Public License v3.0
35 stars 9 forks source link

Begin support for iOS 12.2 TV accessory #3

Closed solowalker27 closed 5 years ago

solowalker27 commented 5 years ago

I was asked by some people to look into adding support for iOS 12.2's new TV accessory to this plugin. I began the work, but unfortunately my projector doesn't support CEC well so I can't fully test this. I'm open to continuing the work but would need responsive testers to debug with, assuming it doesn't just work. 😃

You may consider merging this into another branch to test with but allow wider access and visibility.

dominick-han commented 5 years ago

Now that's interesting...

dominick-han commented 5 years ago

I will definitely restart development based on this PR and test it fully on my TV :) Hopefully it gets done by the end of the week or earlier next week

solowalker27 commented 5 years ago

Awesome! Thanks for considering it.

dominick-han commented 5 years ago

I'm installing iOS 12.2 beta on my phone right now (Glad to see my $99 annual membership isn't going to waste)

dominick-han commented 5 years ago

I merged it into a branch in my repo, so I can test it further and maybe add the input option (don't know if it's there already)

dominick-han commented 5 years ago

Is that the normal workflow for GitHub? (I've used git in enterprise teams so we are working off different branches in the same repo)

solowalker27 commented 5 years ago

That's totally fine. 👍

I tried to add inputs. Check out addSources() for that. It's supposed to iterate through all the found devices and add each as an Input.

dominick-han commented 5 years ago

Is there a specific homebridge version that I need to support the new accessory?

solowalker27 commented 5 years ago

Oh, yep. I missed that in that package.json. Sorry. It's 0.4.46.

dominick-han commented 5 years ago

Looking to rename the plugin, "homebridge-tv"?

solowalker27 commented 5 years ago

I have no strong feelings on that.