Closed ghost closed 12 years ago
ShaneQful
commented
12 years ago Please read the style guide before making syntax and aesthetic changes because most them in this case are wrong although they are at least consistent. I have fixed the style in the jquery.jb.js file so it complies with the google style guide if you want a reference of how it's supposed to be done. http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Strings#Strings
ghost
commented
12 years ago "Wrong"? I don't know what you mean. When I initially submitted the initial code for the jb namespace I made sure that it was JS Lint approved and that it met the Google guide. No one then made any comments saying it was wrong. I just made changes to the jb level and the templates. Would you kindly please explain is wrong?
Is it the var callback instead of "callback" : function ()? also I am not sure it the templates should also be in quotes. Also the Google guide does not cover JSON.
ShaneQful
commented
12 years ago Sorry its the mixture of your code with the other code and wrong was probably to harsh a word but the style says the string should use ' quotes and not " quotes. Also JSON is part of javascript and is at least by proxy covered in the google style guide.
In terms of jslint it's not your code but the code to do with the feeds which I fixed to be lint compliant but this commit would have it put back the old way.
dominickm
commented
12 years ago @Technifix If you like and since I should have some free time on Sunday, I can take a look at the code if you want. I haven't checked it out fully yet. You said it passed JSLint for you? That's good!
However, I think ShaneQful is talking about more style issues.. .is that correct? If so, he is correct that it is important the everyone adhere to the same standards etc including little formatting things.
I know that having pull bounced back for small stuff can be annoying (happens to me all the time because of brackets and small things like that). It's all for the greater good.
-- via Code Journal by Fingertip Tech, INC
ghost
commented
12 years ago @dominickm Feel free to check the code. Which of course you can use a web kit based browser to see it action. The code isn't really special yet. I use the jslint plugin for notepad++.
On an other topic please can do code journal in Qt so that it is portable to Linux and Windows. The git hub app for windows is not very good. I would gladly buy it out side of a app store.
@ShaneQful As frustrating as it is, I can see what you mean. In future could you please be specific when you find something you think should be different. Saying something is wrong, bad, need work...just leaves me asking the question what part? where? It makes the assumption that I know exactly what you mean.
The thing I'm finding the most frustrating is that it has been 2 months and the best we have is a generic looking navigation system. I don't mind code being thrown back... Since it is an opportunity to grow as a developer. However I feel we haven't been very productive and that for best of 5-6 weeks there has been little conversion during the process. I sorry if this sounds negative, I understand that this is a community project and I am committed to contributing my work to this app.
Should I re commit with the suggested changes?
Fixed: spelling mistakes on icon files.
Create CSS File: jquery.mobile.customicons.css with the css needed to use these icons inside of jQuery Mobile. For Example <a href="#now-playing" data-theme="a" data-icon="disk" data-iconpos="top">.
Changed: JSON to use quotes eg. pause is now "pause".
Fixed: jb.series to jb.latest to save future confusion. Ammended the html to match. Fixed: jb.latest.get so that it uses the same look and feel as the other list items in the shows section.
Changed: the footer tab items so that they now have icons. Changed: list view items icons to thumbnails.