search

dominickm / jupiter_broadcasting_mobile_community

The Jupiter Broadcasting community project.
Other
100 stars 17 forks source link

Switched to JPlayer for ease of use #25

Closed ograycode closed 11 years ago

ograycode commented 12 years ago

Switched from the html audio 5 to JPlayer for ease of use. The reasoning behind this is JPlayer is well documented, has a community sorrounding it, and supports playing video. This switch will also make it easier to skin the player to our liking, as shown.

Feel free to tear it all apart. This was done pretty quickly.

ShaneQful commented 11 years ago

I can't see that much that we get from the API that we don't get from HTML 5. Is there anything particular you would like this for; that make's this nicer than the HTML5 API because we can do some nice theming and use the js controller already for the HTML5 API. The HTML5 API also looks simpler?

ograycode commented 11 years ago

You are right, @ShaneQful, I just found the documentation at: https://developer.mozilla.org/en-US/docs/Using_HTML5_audio_and_video

Before throwing this together, I searched and couldn't find any useful documentation for the player.

I suppose the only real advantage is pre-fetching, but it looks like we can do that as well.

For now, I'll just close this, as it appears that there is no real need for it as I thought there was.

ShaneQful commented 11 years ago

Look if you are more comfortable with the API I don't mind using it. I was looking for useful discussion on whether we should have a layer of abstraction like this above the player admittedly I think jplayer loses a lot of its best features on mobile due to a lack of flash but still

ograycode commented 11 years ago

I did it primarily because I couldn't find an easy way to skin the html5 player as a lot of it looked to be undocumented. I would rather not have the extra weight of JPlayer if it's not needed, and in this case, it doesn't appear to be needed, at least not at this time.

Now that I found a source of documentation for the html5 player, I would rather move forward with the pure html5 implementation.

Right now, the only advantage I can see to using JPlayer is using the same object to play both video and audio.

ShaneQful commented 11 years ago

I agree, we will leave it in that case.