search

dominicstop / react-native-ios-context-menu

A react-native component to use context menu's (UIMenu) on iOS 13/14+
MIT License
544 stars 25 forks source link

Minimum Deployment Target: iOS 13.4 #97

Open timothyerwin opened 7 months ago

timothyerwin commented 7 months ago

I think these libraries are a bit out of date? They are using iOS 13.0, but in the latest packages we have 13.4 now.

  /Users/gold/github/node_modules/react-native-ios-utilities/ios/Sources/Extensions+Helpers/RCTView+Helpers.swift:8:8 Compiling for iOS 13.0, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.4: /Users/gold/Library/Developer/Xcode/DerivedData/avezvxkyzxtmrpfbdhjsxddygqbd/Build/Products/Debug-iphonesimulator/ExpoModulesCore/ExpoModulesCore.framework/Modules/ExpoModulesCore.swiftmodule/x86_64-apple-ios-simulator.swiftmodule
nandorojo commented 7 months ago

I think you can set this version in your expo-build-properties config.

timothyerwin commented 7 months ago

I think you can set this version in your expo-build-properties config.

I'm using RN bare flow...where do I put this? package.json?

timothyerwin commented 7 months ago

I'm using the latest of everything. So, I'm guessing 13.4 is required by Expo Modules for a reason so, what I need is for the spec packages here to be bumped to 13.4 I think.

timothyerwin commented 7 months ago

https://github.com/expo/expo/blob/main/packages/expo-modules-core/ExpoModulesCore.podspec#L28

nandorojo commented 7 months ago

If you’re using bare RN I assume you set the minimum deployment version in your pod spec.

With expo dev clients you set it in your config plugins in app.json