search

donejs / bitballs

A basketball tourney application.
https://donejs.com/bitballs.html
MIT License
11 stars 17 forks source link

Memory leak in <tournament-details> #260

Closed matthewp closed 8 years ago

matthewp commented 8 years ago

There's a memory leak in the <tournament-details> ViewModel which is created by binding to the Game model's length property. Because the game model is in the instance store this binding is never torn down. Would be fixed by https://github.com/canjs/can-define/issues/15

Direct fix will be to move the binding to the component's inserted event, and removed in the removed event.

frank-dspeed commented 8 years ago

I think this can be clossed right?

justinbmeyer commented 8 years ago

yep, thanks!