search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
8 stars 38 forks source link

Added new setting to "Copy activity" #179

Closed AraPraxis closed 1 year ago

AraPraxis commented 1 year ago

The new moodle version allows users to be able to backup activities, without being able to edit the activities.

The sharing cart plugins relies on the edit feature, before it's able to show the sharing cart copy button, or before it's possible to drag and drop.

If a user has access to backup activities but not manage, a new view is shown to copy activities. (Works like "Copy section") Note that even though the setting is enabled, the "copy activity" will not be shown, if a user can manage activities.

donhinkelman commented 1 year ago

Thanks, Anders, for all these updates for Sharing Cart into Moodle 4.3. Do you recommend I merge these now? Or test it myself first, which may take time.

donhinkelman commented 1 year ago

Also, what does "Some checks were not successful" mean?

AraPraxis commented 1 year ago

Hello @donhinkelman If you wish to test it before merging, I can provide you with the scenario needed to test the new implemented feature, as it relies on the capability of the user roles.

"Some checks were not successful" means that some of the test scenarios were not run correctly. But in this scenario does not mean anything for the plugin. Someone has created a test suite to check the code on Moodle 4.1 but with PHP version 8.2... PHP version 8.2 was implemented in Moodle 4.2.3 & 4.3+ hence the "error" message - I'll note it and we'll remove it, when updating the plugin again :-)