donkeyshot / phybreak

Outbreak reconstruction with sequence data
8 stars 9 forks source link

collection dates unclear #5

Open tigerxu opened 6 years ago

tigerxu commented 6 years ago

Hi Don,

In my case, the collection dates of certain strains are unclear, e.g. like these 2009-11-XX or 2009-XX-XX. Is it possible to apply phybreak for such analysis?

Thanks!

Zhuofei

donkeyshot commented 6 years ago

Hi Zhuofei It's not possible to explicitly include uncertainty about collection dates.  If for all samples you only have months you can enter collection times as nth month. If precision is different for different samples, you will have to choose specific dates for some samples. I could imagine implementing collection intervals which phybreak could interpret as a uniform prior for the collection date. Would that be useful for you? Best wishesDon -------- Oorspronkelijk bericht --------Van: tigerxu notifications@github.com Datum: 22-10-18 08:52 (GMT+01:00) Aan: donkeyshot/phybreak phybreak@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Onderwerp: [donkeyshot/phybreak] collection dates unclear (#5) Hi Don, In my case, the collection dates of certain strains are unclear, e.g. like these 2009-11-XX or 2009-XX-XX. Is it possible to apply phybreak for such analysis? Thanks! Zhuofei

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/donkeyshot/phybreak","title":"donkeyshot/phybreak","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/donkeyshot/phybreak"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"collection dates unclear (#5)"}],"action":{"name":"View Issue","url":"https://github.com/donkeyshot/phybreak/issues/5"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/donkeyshot/phybreak/issues/5", "url": "https://github.com/donkeyshot/phybreak/issues/5", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "collection dates unclear (#5)", "sections": [ { "text": "", "activityTitle": "tigerxu", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@tigerxu", "facts": [ { "name": "Repository: ", "value": "donkeyshot/phybreak" }, { "name": "Issue #: ", "value": 5 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"donkeyshot/phybreak\",\n\"issueId\": 5,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"donkeyshot/phybreak\",\n\"issueId\": 5\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/donkeyshot/phybreak/issues/5" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 399222025\n}" } ], "themeColor": "26292E" } ]

tigerxu commented 6 years ago

Hi Don,

Many thanks for your prompt reply! I understand. I will try to use nth month for sampling dates. Sampling during an outbreak often has a clear start and end date. It's useful to add collection intervals.

In my collected data (~300 viral genomes and metadata during 27 years, I found some highly genetically similar strains are clustered into a single group which is likely to belong to a long-term epidemic over 10 years. In the FMDV case using phybreak, all isolates are collected within several months. So I'm wondering if it is suitable for using phybreak to analyze these data with a long time range?

Best wishes, Zhuofei