search

donmccurdy / glTF-Transform

glTF 2.0 SDK for JavaScript and TypeScript, on Web and Node.js.
https://gltf-transform.dev
MIT License
1.4k stars 149 forks source link

Deno runtime support #457

Open donmccurdy opened 2 years ago

donmccurdy commented 2 years ago

Continuing from https://github.com/donmccurdy/glTF-Transform/pull/380 and #379, I intend to support Deno as an environment. The I/O class has been added, but a few remaining things to do:

Context:

TypeScript's magic ./foo → ./foo.ts resolution is causing quite a headache here.

rotu commented 1 week ago

It seems like DenoIO.write doesn't exist and NodeIO works fine on deno. Maybe DenoIO isn't needed?

donmccurdy commented 1 week ago

I'm not caught up on the latest changes in Deno v2 yet, but I understand they've prioritized compatibility with the Node.js ecosystem, and I agree that a DenoIO class isn't strictly required. That said — I think I do prefer to keep it, even if it's just an empty subclass of NodeIO. Deno isn't Node.js, and I think deserves equal standing as an I/O class. It's possible we may want a slightly different implementation at some point, too.