donnell74 / CSC-450-Scheduler

MIT License
1 stars 1 forks source link

Showing added constraint #41

Closed donnell74 closed 9 years ago

prichey commented 9 years ago

What do these numbers by the side of the constraints mean? screenshot 2014-11-18 23 41 11

Also, I think 'View Constraints' works better than 'Toggle Constraint' because what we have now makes it seem like we're turning on or off the constraints which (as I understand it) is not what's happening

CameronHKIng commented 9 years ago

I agree with Preston

CameronHKIng commented 9 years ago

The numbers are the fitness score (or if it's is_valid type, pass/fail)

CameronHKIng commented 9 years ago

I would be fine with merging this under the condition that we add some text to the view saying that this isn't final. We can then merge this in and continue it next sprint. I don't want it unmerged because then it will conflict with the standards branch

kylenovak commented 9 years ago

^ sounds good to me

prichey commented 9 years ago

I guess that makes sense.

But if we're doing this from a customer perspective I'm not sure that those numbers are necessary / useful. Does the customer need to know about fitness score? Does the 1 beside some constraints mean that they have a fitness of 1? Will the customer know that 1 means 'pass' and 0 means 'fail'?

I think these are all worth considering, but I agree with Cameron that it's fine being merged it and dealt with in next sprint

prichey commented 9 years ago

Is 'lab on tr: CSC 320 001' a constraint? I think that's also confusing from a customer standpoint

CameronHKIng commented 9 years ago

Yes, it is. I agree that constraint names should be more descriptive. If you want to, you can change them all, but make sure that the logic doesn't break (for duplicate constraints and such).

Also, I added some Trello tasks for it.

prichey commented 9 years ago

I'm fine merging this is as is and explaining in the presentation that it will be refined for the final version - I definitely don't have the energy to take it over tonight

CameronHKIng commented 9 years ago

:+1: