search

dontcallmedom / github-notify-ml

index.py is a python CGI script that provides a Webhook to be used as a github hook endpoint to send mail to a set of email addresses when specific GitHub events happen
15 stars 17 forks source link

Quoted printable encoding issues when receiving notification mails in Evolution or Mail.app #8

Closed drott closed 9 years ago

drott commented 9 years ago

Thanks for the script, first of all!

Having configured it for the Second Screen WG we see an issue with the notifications for pull request, in this example, the source of the mail (with "Received" headers removed):

Date: Thu, 12 Feb 2015 08:32:36 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Anssi Kostiainen via GitHub <sysbot+gh@w3.org>
To: <public-secondscreen@w3.org>
Message-ID: <pull_request.opened-29160635-1423729955-sysbot+gh@w3.org>
X-W3C-Hub-Spam-Status: No, score=-2.2
X-W3C-Hub-Spam-Report: ALL_TRUSTED=-1, AWL=-1.203, T_RP_MATCHES_RCVD=-0.01,
 URIBL_BLOCKED=0.001
X-W3C-Scan-Sig: lisa.w3.org 1YLpCO-0007cn-JT
 7645b565d1324b751b375bcba99614bd
X-caa-id: 4f3ae2fc6f
X-Original-To: public-secondscreen@w3.org
Subject: [presentation-api] Pull Request: Use the custom W3C Document
 License defined  in the Charter
Archived-At:
 <http://www.w3.org/mid/pull_request.opened-29160635-1423729955-sysbot+gh@w3.org>
Resent-From: <public-secondscreen@w3.org>
X-Mailing-List: <public-secondscreen@w3.org> archive/latest/195
X-Loop: public-secondscreen@w3.org
Resent-Sender: <public-secondscreen-request@w3.org>
Precedence: list
List-Id: <public-secondscreen.w3.org>
List-Help: <http://www.w3.org/Mail/>
List-Post: <mailto:public-secondscreen@w3.org>
List-Unsubscribe:
 <mailto:public-secondscreen-request@w3.org?subject=unsubscribe>
Return-Path:
 public-secondscreen-request+bounce-dominik.rottsches=intel.com@listhub.w3.org
X-MS-Exchange-Organization-AVStamp-Mailbox: NAI;57084253;0;novirus
X-MS-Exchange-Organization-AuthSource: ORSMSX104.amr.corp.intel.com
X-MS-Exchange-Organization-AuthAs: Anonymous
MIME-Version: 1.0
X-Evolution-Source: 1391783486.6368.4@drottsch-MOBL1

anssiko has just submitted a new pull request for=20
https://github.com/w3c/presentation-api:

=3Dse the custom W3C Document License defined in the Charter =3D=0A=
The group's Charter defines a custom Document License [1] the=20
documents produced by this group should use. To that end, I updated=20
the Editor's Draft as well as the FPWD snapshot in staging=20
accordingly.

@tidoust Pubrules checker naturally does not understand this custom=20
Document License, so this needs to be checked manually.

[1] http://www.w3.org/2014/secondscreen/charter.html#doclicense

See https://github.com/w3c/presentation-api/pull/54

The subject of the PR is: Use the custom W3C Document License defined in the Charter

However, when receiving the mail, it's mangled to: =3Dse the custom W3C Document License defined in the Charter =3D=0A=

dontcallmedom commented 9 years ago

https://lists.w3.org/Archives/Public/public-secondscreen/2015Feb/0073.html seems to show it not mangled — are you sure it's not a bug in evolution or Mail.app for quoted printable?

or are you suggesting the tool should avoid using quoted printable because it's poorly supported in MUA?

dontcallmedom commented 9 years ago

I eventually realized that the message in the archives was actually mangled but in a subtle way, and found a bug in my script after further exploration (the body was not getting encoded as quoted printable); it should be fixed now.

drott commented 9 years ago

Thanks for the fix!