search

doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.15k stars 390 forks source link

Support treemacs-ext with nerd-icons instead of all-the-icons #823

Open tam5 opened 6 months ago

tam5 commented 6 months ago

Describe your request

Somewhat recently doom dropped all-the-icons in favor of nerd-icons.

As part of that some of the extra visual tweaks present in doom-themes-ext-treemacs.el, like hiding the modeline for example, seem to have been lost.

What do ya'all think would be a recommended fix? Add a new extension for treemacs-with-nerd, split out treemacs-ext to separate icon handling from the rest, add additional conditional logic to existing treemacs-ext to just skip the all-the-icons stuff?

Briefly explain its use-case

Using doom with treemacs.

sebastiaanspeck commented 5 months ago

I do not know what the fix would be, but I have at least opened a PR to show the modeline again https://github.com/doomemacs/themes/pull/824 since https://github.com/Alexander-Miller/treemacs/pull/1049 made the modeline useful again

Velnbur commented 5 months ago

It's actually already done using treemacs-nerd-icons package by updating treemacs-load-theme to nerd-icons (see)

forty commented 6 days ago

FYI that's what I did for the neotree extension https://github.com/doomemacs/themes/pull/816

Sadly it's not as simple as s/all-the/nerd/g, but it's not very complicated either. I don't know if it's the good solution for long term (all the icons is used a bit all over the place in this repo, and I'm not confident enough to do the change everywhere), but it works here for neotree :D