doriordan / skuber

A Scala Kubernetes client library
Apache License 2.0
326 stars 97 forks source link

Added support of projected volumes #311

Closed jacum closed 4 years ago

jacum commented 4 years ago

Projected volumes are very useful, allowing combining of several configmaps/secrets into one and reducing clutter in deployments and applications configs.

I was somewhat surprised not finding support for projected volumes in skuber.

This PR adds the missing pieces.

jacum commented 4 years ago

@doriordan, could you please take a look? I believe the scope is rather small, and using projected volumes will relieve us from writing barocco code for mounting configmaps/secrets

many thanks in advance!

jacum commented 4 years ago

@doriordan, sorry for bothering you again - could you please review this PR?

doriordan commented 4 years ago

Hi @jacum I'll take a look, thanks for the PR.

jacum commented 4 years ago

@doriordan, my apologies for impatience just to remind you that we are equally eager to either proceed implementing any of you suggestions to improve this PR, or see it merged ;)

jacum commented 4 years ago

@doriordan - changes for your remarks were implemented and thanks for pointing to the specs

doriordan commented 4 years ago

Just left one more review comment on the changes...I think it is ready once that is resolved.

jacum commented 4 years ago

Just left one more review comment on the changes...I think it is ready once that is resolved.

hope it's all done now...

doriordan commented 4 years ago

LGTM - thanks for the PR

jacum commented 4 years ago

@doriordan, one more question - I see that last release of skuber was quite a while ago... any plans for the new release in the near future?

doriordan commented 4 years ago

I plan to make another release over coming days

jacum commented 4 years ago

I plan to make another release over coming days

great news, thanks!

doriordan commented 4 years ago

FYI - v2.5.0 has just been released

jacum commented 4 years ago

Many thanks, @doriordan !