dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
866 stars 467 forks source link

Unable to reuse content inside the variants #25901

Closed bryanboza closed 10 months ago

bryanboza commented 1 year ago

Problem Statement

In experiments, users are unable to reuse content inside the variants in dotCMS. When attempting to reuse content from another container section, the content does not appear correctly in the list of contents. Even if you are inside the same variant

https://github.com/dotCMS/core/assets/2641437/fd9e341c-4822-4c5b-b7a9-c014f20bae79

Steps to Reproduce

Acceptance Criteria

dotCMS Version

Tested on master

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

victoralfaro-dotcms commented 1 year ago

Tested using dotcms/dotcms:master_0b9267e_SNAPSHOT New content added to variant Image Content found when adding Image Image Preview Image Image

bryanboza commented 1 year ago

After the last changes, now we are unable to see the regular contents when you are into the variant, we are just listing the contents that you create inside the variant Here the video:

https://github.com/dotCMS/core/assets/2641437/ead921aa-75a4-4003-a9fa-fdc9a28f7842

oidacra commented 1 year ago

IQA Passed:

Bug fixed

Sep-21-2023 13-09-12

bryanboza commented 1 year ago

We still having problems here:

We are inconsistent between the contents that we show with the traditional way to add content to a page//variant and with the contents that we show from the content pallet

john-thomas-dotcms commented 1 year ago

So, to clarify the issue highlighted by @bryanboza in his last comment:

When you create new content while editing a variant, then, while editing that variant:

  1. The new content will be displayed in the content list when using the "+" button.
  2. But the new content will not be displayed in the content palette (even while editing that variant).
oidacra commented 1 year ago

FIxed with https://github.com/dotCMS/core/pull/26338

victoralfaro-dotcms commented 1 year ago

Tested using image: dotcms/dotcms:master_534774e_SNAPSHOT New content added to variant's container

image

Content found when trying to add to the same variant's second container using the + button

image

Content found when trying to add to the same variant's second container from the content palette

image
bryanboza commented 1 year ago

We need to refresh the content palette when you change the language drop down, this because after you change the lang, we are refreshing the page, but if you try to add a new piece of content we are still showing the list of contents in the other language.

https://github.com/dotCMS/core/assets/2641437/0633d0e7-e0c1-4e6b-b7b6-41879de71e77

This is happening just on experiments, b/c on the regular edit mode when you change that value we are redirecting to the preview tab, then if you try to edit we refresh the whole page.

hmoreras commented 1 year ago

Refresh the content palette with lang change: https://github.com/dotCMS/core/pull/26450

dsilvam commented 1 year ago

Passed Internal QA: Content is being refreshed and showing in the proper language upon changing it in the Language dropdown.

bryanboza commented 1 year ago

Fixed, tested on master // Docker // FF

Now it is working as expected, but we still having problems with the content pallette, this problem is a separated issue and was moved to this card: https://github.com/dotCMS/core/issues/26773