search

dotJEM / angular-routing

Enhanced state based routing for Angular applications!
https://dotjem.github.io/angular-routing/
MIT License
75 stars 9 forks source link

jem-view: Update for angular-1.2. #69

Closed groner closed 10 years ago

groner commented 10 years ago

This is a continuation of the work started in #67. I think I have addressed all the concerns discussed there.

groner commented 10 years ago

I've started to update the substates example so I can see how animations are working. I'll add commits when that is ready.

jeme commented 10 years ago

Not sure with the new API, but i know that animations of views was tricky with the old API... especially if you had more than one "root node" in your template, so in the current sample there was an attempt to mitigate that, however it caused for some layout issues so it wasn't completed.

I hope that the new API fixes some of those issues maybe...

View code looks good.

jeme commented 10 years ago

Id didn't seem like the changes to the sample was on the door steps, so to avoid any other conflicts, I have merged this into the 1.2 branch.

Unfortunetly I had to do the merge by hand due to new changes to the jem-view on the main branch which was rebased to the 1.2 branch.

groner commented 10 years ago

@jeme Your merge looks fine to me. I've been focused on a work project that's using angular-routing. I may find time this weekend to look at updating the samples.

jeme commented 10 years ago

That's perfectly understandable, and as the samples in general will need a major overhaul, you don't need to use time on it if you don't have the time...

But I didn't wan't to let your PR hang for to long, after all that only makes it harder to merge.