dotkernel / api

DotKernel's PSR-7 REST style API built around the Mezzio API skeleton.
https://docs.dotkernel.org/api-documentation/
MIT License
35 stars 5 forks source link

bump for doctrine orm 2 -> 3, dbal 3 -> 4 through roave psr container #283

Closed cPintiuta closed 3 months ago

github-actions[bot] commented 3 months ago

Qodana for PHP

82 new problems were found

Inspection name Severity Problems
Undefined method 🔶 Warning 62
Undefined class 🔶 Warning 12
Undefined namespace 🔶 Warning 8

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
cPintiuta commented 3 months ago

Any idea why the uuid column has moved towards the end of the table, before the created column? I guess Doctrine3 treats differently an entity when it extends another entity.

Yes, because those columns comes from AbstractEntity, we need to declare this class with MappedSuperclass attribute, and if we want the uuid to appear first and timestamps last, we need to split them.

cPintiuta commented 3 months ago

@alexmerlin The problem from github actions is dot-data-fixtures who request doctrine/data-fixtures ^1.5. support for orm 3 and dbal 4 was added from 1.7. We need to disquss how we aproach this to be sure that it works for api v4 and v5.