search

dotnet / android-libzipsharp

A managed wrapper (and then some) around libzip (https://libzip.org/)
MIT License
30 stars 12 forks source link

Bump to microsoft/vcpkg@c8696863d3 #133

Closed pjcollins closed 10 months ago

pjcollins commented 10 months ago

Changes: https://github.com/microsoft/vcpkg/compare/94ce0dab56f4d8ba6bd631ba59ed682b02d45c46...c8696863d371ab7f46e213d8f5ca923c4aef2a00

A recent build attempt failed downloading various mingw dependencies:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8898600&view=logs&j=dcf9cb13-bc72-55bf-54b2-a34a02160417&t=c05507e5-95d2-500e-0fcb-12f725f05b68

Error: Failed to download from mirror set:
https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst: failed: status code 404

Bumping to the latest vcpkg release tag appears to fix this.

pjcollins commented 10 months ago

@grendello @dellis1972 I'm not sure if this is the best way to fix the issue I hit trying to build recently, and am not entirely sure how many vcpkg dependency versions may be changing as a result of this change. Do either of you have any thoughts on how best to resolve the recent build break?

grendello commented 10 months ago

In the long run, it might make sense to switch away from vcpkg to https://cmake.org/cmake/help/latest/module/FetchContent.html#module:FetchContent, but if the bump fixes the issue now, then I'm all for it.