search

dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.
MIT License
671 stars 349 forks source link

Move IncludePreReleaseLabelInPackageVersion property evaluation out of the target #15256

Closed NikolaMilosavljevic closed 1 week ago

NikolaMilosavljevic commented 1 week ago

Fixes regression introduced with https://github.com/dotnet/arcade/pull/15239

This change is not yet consumed by runtime repo, but I have reproed the issue in local build.

Package version is missing the prerelease part of the version. This is a result of property evaluation order. IncludePreReleaseLabelInPackageVersion property needs to be evaluated before it is used.

I've tested the fix locally in runtime build and also in my pending work to enable new installer infra in sdk build.