Use edge for blazorwasm config by default

[connor4312]

We now have integration with the Edge Tools team that adds an "inspect" icon and functionality to Edge sessions. We should default to Edge so that blazor debugging gets this functionality too.

Currently users manually need to opt-in by specifying browser: edge:

{
  "type": "blazorwasm",
  "name": "Launch and Debug Blazor WebAssembly Application",
  "request": "launch",
  "browser": "edge",
  "url": "http://localhost:5000"
}

@captainsafia / @codepo8

[javiercn]

@connor4312 thanks for contacting us.

@captainsafia @danroth27 do you have any thoughts on this? Moving to next sprint planning for consideration. Marking as good first issue, help wanted in case we decide to go this route

[ghost]

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[codepo8]

Hey @javiercn, I'm the PM for the integration on the Edge DevTools side, if you need any help or more information, feel free to reach out.

[javiercn]

@codepo8 thanks for letting us know.

I'm not very involved in this feature, hence why I passed the ball to @captainsafia (main dev on the area) and @danroth27 (the PM for Blazor)

[captainsafia]

Yep -- this is something we discussed doing via email.

The change itself is pretty trivial. We'll need to update the default value here:

https://github.com/dotnet/aspnetcore-tooling/blob/abb2775cd1185b50f0cfc404e7316e8826f2e116/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.Extension/package.json#L84

and here:

https://github.com/OmniSharp/omnisharp-vscode/blob/19b027b91ae99b1010af249a1a9131b8cdf45ae0/package.json#L3179

@codepo8 Would you be interested in updating the values as needed here?

[danroth27]

Have we tried out the debugging experience with Edge on macOS? Any known issues there?

[connor4312]

Debugging Edge on macOS work well, though I haven't tried Blazor + macOS + Edge.

[captainsafia]

@danroth27 Yeah, I tried it recently. No major issues with Edgeium.

[codepo8]

I'm a Mac user, all good.

On Tue, Jun 1, 2021 at 11:23 PM Safia Abdalla @.***> wrote:

@danroth27 https://github.com/danroth27 Yeah, I tried it recently. No major issues with Edgeium.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dotnet/aspnetcore/issues/33088#issuecomment-852454730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADJRH6FHQNJ5TNMEOEBOTTQVFUDANCNFSM45U5QZ2Q .

[ghost]

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[taha-ghadirian]

Hello! @mkArtakMSFT can I work on this issue? I hope you could assign it to me ;)

[prnam]

In my opinion it should use / open default browser set by user in their machine (to avoid monopoly concerns in future / considering .NET Foundation working in favour of MSFT Corp as deviation from objective or bylaws etc.) and then also have an option of using Safari, Firefox accepted as valid values.

[connor4312]

js-debug uses the default-browser module to check the browser on any platform, to which I PR'd in support for Windows a few months ago 🙂

[DarCampbell]

Can I contribute to this change?

[captainsafia]

@DarCampbell Sure! The change would need to be made in a different repo though. https://github.com/dotnet/aspnetcore/issues/33088#issuecomment-852441134 outlines the required changes.

[TanayParikh]

Thanks @DarCampbell. @captainsafia is this change done already given https://github.com/dotnet/razor-tooling/pull/5666 & https://github.com/OmniSharp/omnisharp-vscode/pull/4847?

Do we need to update:

https://github.com/dotnet/razor-tooling/blob/e43ce65bda7c105463e3775e8beb89cc48444ea1/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode/src/BlazorDebug/BlazorDebugConfigurationProvider.ts#L94

to something like:

type: configuration.browser === 'chrome' ? 'pwa-chrome' : 'pwa-msedge',

[captainsafia]

Thanks @DarCampbell. @captainsafia is this change done already given dotnet/razor-tooling#5666 & OmniSharp/omnisharp-vscode#4847?

Yep. This is done now via https://github.com/OmniSharp/omnisharp-vscode/commit/1300a755cd67bd19a85355991f29ffaf14d127b9.

[TanayParikh]

Thanks for confirming, closing out the issue.