Open JamesNK opened 1 year ago
Output Caching metrics might be another good idea. I'm also wondering whether anything makes sense around health checks - although they can probably be seen within the scope of the existing metrics.
This is mostly for outside kestrel, right? #47831 covers the remaining work there?
Yes
cc @halter73 @JeremyLikness
As someone working in the authentication space and looking at metrics currently, I'd be interested in helping out with this.
The first step is to figure out what the metrics are. The issue includes some notes from discussing metrics with @halter73 @JeremyLikness. I think they're the folks that need to come up with what the spec is we want in .NET 9.
We ended up cutting this out from .NET 9 as we don't have capacity to tackle this in time.
Issue https://github.com/dotnet/aspnetcore/issues/47536 adds metrics for existing counters.
We should investigate where adding new metrics makes sense in ASP.NET Core. Metrics are easier to add and test than old event counters. And tags make them more powerful.
Initial ideas:
AuthZ
AuthN
Sign in handler
Sign out handler