Open BillWagner opened 6 years ago
Yes, here is the list for C#. It is largely chronological. To get details, the easiest it to load the project, and find references. That will find tests that report a given error.
@BillWagner I just tried to compare the pages under dotnet/docs/tree/master/docs/csharp/language-reference/compiler-messages
with list for C# and it seems as though are missing most of the compiler messages (we have 136 entries in docs vs. approx. 1500 values in the ErrorCode
. So I think it makes sense to "chop up" this issue into a lot of smaller tasks (both make both the work and the review work manageable).
@mikkelbu That's the plan @rpetrusha are working on putting together. We'll also have a similar project for VB. Stay tuned. We'd love your help.
@mikkelbu have you considered pages under dotnet/docs/tree/master/docs/csharp/misc
? There are about 800 compiler messages, probably mostly compiler errors, in that folder.
(There is the issue to combine those two locations: #1491)
@pkulikov No, I forgot about that issue (eventhough I looked at it this week). Then it seems that this it is a smaller task, but still a large task IMHO.
As I understand, the first priority is to document error messages. That can be a smaller task, while documenting all the compiler warnings might be an epic :)
There's also #2363, which treats storing C# and VB error messages/warnings in a unified directory per language. Moving files from a misc
directory to the directory in language-reference is fairly trivial. Since we'd be moving everything, we can just do a global redirect of all requests for docs.microsoft.com/dotnet/csharp/misc to docs.microsoft.com/dotnet/csharp/language-reference/compiler-messages. But you're right, @pkulikov, that documenting all the compiler warnings might be epic. Providing genuinely useful content with examples is even more epic.
I've assigned this to the current milestone, with the goal of having the following actions completed during this sprint:
@rpetrusha Comment on this plan, or add new tasks that you think are reasonable.
This looks good, @BillWagner. I think that we can link to the project to track tasks from the community contributor's project. In the project to track tasks, we should also include #1491 on it. I think that that should be the first item of work.
Messages are in the roslyn resource file
Messages are in the roslyn resource file
I can't find the message for CS0043 that's already documented in that link. Even a search for it in the dotnet organization gives only the documentation result. A search in roslyn has no results too.
@BillWagner , Do you know anything about that ? Could that mean that this compile-error was "totally removed" and is outdated now ?
Update: Looking at ErrorCode.cs. Seems like this error isn't used by roslyn.
I've opened #14737 for this specific one.
This issue has been closed as part of the issue backlog grooming process outlined in #22351.
That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs
team for visibility.
@BillWagner You'll probably want to re-open this.
Related to #24002
I'm almost certain we haven't added new warnings and error messages since C# 6.0 (and maybe earlier).
@jcouv is there a good list in the roslyn repo to track down what should be covered?
See #5390-comment for details.