dotnet / eShop

A reference .NET application implementing an eCommerce site
MIT License
6.49k stars 1.94k forks source link

Fix XamlC warnings in .NET MAUI app #585

Closed simonrozsival closed 1 month ago

simonrozsival commented 1 month ago

This PR fixes XamlC warnings in the .NET MAUI app that are related to @jamesmontemagno's upgrade to .NET 9.

The changes are straightforward. It was only necessary to add the missing x:DataType attribute to the XAML files and reenable the warnings. Adding the annotations revealed that the FiltersView.xaml bindings were incorrect (even though this make little impact since as far as I can tell it isn't used currently).

This is a prerequisite to making this app work with NativeAOT. It will be still necessary to switch to source-generated JSON serialization and update the CommunityToolkit once it supports .NET 9 and NativeAOT.