search

dotnet / ef6tools

This is the codebase for the Entity Framework 6 and LINQ-To-SQL designers.
MIT License
35 stars 14 forks source link

Handle Keywords with spaces #41

Closed ryanbrandenburg closed 1 year ago

ryanbrandenburg commented 1 year ago

Fixes https://developercommunity.visualstudio.com/t/VS2022-175-no-longer-allows-use-of-conn/10288655.

jasonmalinowski commented 1 year ago

What is this fixing?

ErikEJ commented 1 year ago

Is this about MDS support?

ErikEJ commented 1 year ago

@robertmclaws FYI (re your failing designer!)

robertmclaws commented 1 year ago

Does the same thing need to happen for the following connection string fields:

ErikEJ commented 1 year ago

@robertmclaws No, see https://learn.microsoft.com/en-us/dotnet/api/microsoft.data.sqlclient.sqlconnection.connectionstring?view=sqlclient-dotnet-standard-5.1

"provider connection string" belongs to EntityClient, not SqlClient.

ryanbrandenburg commented 1 year ago

Sorry about the lack of info in the original post, I was mostly creating the PR to get a test build running and was in a rush.

Is this about MDS support?

Yes. When other parts of VS moved to MDS they changed the way that EF6 Designer connection strings would be generated to a way that is not compatible with other parts of EF6 Designer. We're hoping this fixes https://developercommunity.visualstudio.com/t/VS2022-175-no-longer-allows-use-of-conn/10288655 and a bunch of other issues that we'll be duping out to that one once I've got a second.

@robertmclaws FYI (re your failing designer!)

It's entirely possible they're the same issue since I only know about one EF6 Designer bug in 17.5, if you link to a specific Feedback issue I can confirm (or if I mark that issue as a duplicate of this one you'll know).

ErikEJ commented 1 year ago

@ryanbrandenburg Thanks! I am able to run the designer with MDS if I avoid a broken connection string.

ErikEJ commented 1 year ago

@ryanbrandenburg Which VS version will this be in?