search

dotnet / fabricbot-config

Scripts for managing fabricbot configurations in the dotnet repos
MIT License
4 stars 7 forks source link

Label needs-author-action is not getting automatically applied/removed in machinelearning #1

Closed jeffhandley closed 2 years ago

jeffhandley commented 2 years ago

As observed in https://github.com/dotnet/machinelearning/issues/6098, the needs-author-action label should have been automatically removed when the author commented, but the label was not automatically removed.

This is caused by not having the same set of tasks in the machinelearning repo that we have in the runtime repo. Specifically, the runtime repo has the following tasks related to the needs-author-action label:

  1. Replace needs-author-action label with needs-further-triage label when the author comments on an issue
  2. Add no-recent-activity label to PRs
  3. Needs-author-action notification
  4. PR reviews with \"changes requested\" applies the needs-author-action label
  5. Pushing changes to PR branch removes the needs-author-action label
  6. Author commenting in PR removes the needs-author-action label
  7. Author responding to a pull request review comment removes the needs-author-action label

At present, we don't have those tasks as part of the generated configuration tasks. We need to decide if those tasks should be generated from the scripts in this repository or if we should just have them replicated in each of the repos where that behavior is desired.

/cc @michaelgsharp

jeffhandley commented 2 years ago

There are other tasks directly configured in the runtime repo that aren't configured in the machinelearning repo either. Another example is Assign Team PRs to author. We should review all of the non-area-pod tasks in the runtime repo to see which others we want to apply to the machinelearning repo and which we want to standardize through the scripts in fabricbot-config.