dotnet / fabricbot-config

Scripts for managing fabricbot configurations in the dotnet repos
MIT License
4 stars 7 forks source link

Closing an issue results in double automation of moving the issue to Triaged #20

Closed jeffhandley closed 2 years ago

jeffhandley commented 2 years ago

When an issue is closed, we're seeing artifacts that indicate the issue is moved to the Triaged column twice. While the issue page is open, this shows up on the issue page like this: image

The project board activity stream shows what actually happened: image

Both the fabricbot configuration and the project board preset automation are moving the issue to the Triaged column. This is a race condition resulting in duplicated updates, as fabricbot is initiating the move before the board automation makes the move.

jeffhandley commented 2 years ago

We should consider removing the project board automation presets and make fabricbot the single source of board automation. This would address other race condition or "tug of war" scenarios/risks. Issues #5 and #6 are both also caused by this conflict, and #3 is related too.

jeffhandley commented 2 years ago

Since we already have logic in place to move to the Triaged column when an issue is closed (as part of isTriaged), we can safely remove the board automation for the Triaged column without any code change.

jeffhandley commented 2 years ago

All of the issue triage boards have been updated to remove the Triaged column automation.