search

dotnet / fabricbot-config

Scripts for managing fabricbot configurations in the dotnet repos
MIT License
4 stars 7 forks source link

Refactor PR champion assignment to address race condition #35

Closed jeffhandley closed 2 years ago

jeffhandley commented 2 years ago

The PR champion assignment logic was relying on the user being assigned, but that happens via a fabricbot rule, and rules do not trigger rules. Instead, that logic needs to check to see if:

  1. The PR was in "Needs Champion", and it became assigned to the pod member; or
  2. The PR is not yet on the project board, it matches one of the pod's areas, and it was opened or reopened by the pod member